Skip to content

ams.js simd.js : adding missing attirbutes to jit-related tests so they won't run w/ jit disabled, Fixes #964 #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2016
Merged

ams.js simd.js : adding missing attirbutes to jit-related tests so they won't run w/ jit disabled, Fixes #964 #967

merged 1 commit into from
May 11, 2016

Conversation

@Krovatkin
Copy link
Collaborator

@Krovatkin Krovatkin commented May 11, 2016 •
edited by dilijev
Loading

excluding more jit tests in disablejit mode

Fixes #964

@Krovatkin
adding missing attirbutes
0c0d2c4 
excluding more jit tests in disablejit mode
@Krovatkin
Copy link
Collaborator Author

Krovatkin commented May 11, 2016

fixes #964

@Krovatkin Krovatkin changed the title adding missing attirbutes to jit-related tests so they won't run w/ jit disabled ams.js simd.js : adding missing attirbutes to jit-related tests so they won't run w/ jit disabled May 11, 2016
@Krovatkin
Copy link
Collaborator Author

Krovatkin commented May 11, 2016

@dilijev please take a look at this PR when you have a mnt.
@arunetm could you please help me to merge this PR when its approved by MSFT
just fyi: @nmostafa

@arunetm-zz
Copy link
Contributor

arunetm-zz commented May 11, 2016

@dilijev can you please review this PR. Thanks.

@dilijev
Copy link
Contributor

dilijev commented May 11, 2016

@dotnet-bot test nojit tests please

@dilijev
Copy link
Contributor

dilijev commented May 11, 2016

Fix LGTM but wait for the disablejit tests to pass to ensure the issue is resolved.

@dilijev
Copy link
Contributor

dilijev commented May 11, 2016

FYI @digitalinfinity

@Krovatkin Krovatkin changed the title ams.js simd.js : adding missing attirbutes to jit-related tests so they won't run w/ jit disabled ams.js simd.js : adding missing attirbutes to jit-related tests so they won't run w/ jit disabled, Fixes #964 May 11, 2016
@dilijev
Copy link
Contributor

dilijev commented May 11, 2016

LGTM, all checks passed. Good to merge, @arunetm

@chakrabot chakrabot merged commit 0c0d2c4 into chakra-core:release/1.2 May 11, 2016
chakrabot pushed a commit that referenced this pull request May 11, 2016
@arunetm-zz
[MERGE #967] ams.js simd.js : adding missing attirbutes to jit-relate…
e477b13 
…d tests so they won't run w/ jit disabled, Fixes #964

Merge pull request #967 from Krovatkin:r12_doug
excluding more jit tests in disablejit mode

Fixes #964
@arunetm-zz
Copy link
Contributor

arunetm-zz commented May 11, 2016

Merged. Thanks.

chakrabot pushed a commit that referenced this pull request May 11, 2016
@arunetm-zz
[1.2>master] [MERGE #967] ams.js simd.js : adding missing attirbutes …
69776ab 
…to jit-related tests so they won't run w/ jit disabled, Fixes #964

Merge pull request #967 from Krovatkin:r12_doug
excluding more jit tests in disablejit mode

Fixes #964
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Krovatkin @arunetm-zz @dilijev @msftclas @chakrabot