cross platform: Enable Date features with system default globalization #925
Conversation
lib/Runtime/Base/ScriptContext.cpp
Outdated
| void ScriptContext::UpdateTimeZoneInfo() | ||
| { | ||
| GetTimeZoneInformation(&timeZoneInfo); | ||
| #if !defined(__cplusplus_winrt) && defined(_WIN32) |
There was a problem hiding this comment.
Why adding !defined(__cplusplus_winrt)? It worked before without it.
Linux has tzset(). Does it work here?
There was a problem hiding this comment.
Saw the important message from https://msdn.microsoft.com/en-us/library/90s5c885.aspx
AFAIK using tzset on *nix may depend on the choice of localization.
There was a problem hiding this comment.
Saw the important message from https://msdn.microsoft.com/en-us/library/90s5c885.aspx
I'm unfamiliar with it. It might be possible that chakra.dll can use this API? Maybe better avoid side-fixing it here and file an issue to investigate it separately?
There was a problem hiding this comment.
I'm unfamiliar with it. It might be possible that chakra.dll can use this API? Maybe better avoid side-fixing it here and file an issue to investigate it separately?
Okay, added a comment there instead.
|
LGTM, thanks! |
This PR may require the presence of #915
|
Updated this PR. Since we haven't merged #915 yet, combination was enabling some windows only features. After both PRs merged, we should have a functioning DateTime support. |
|
@dotnet-bot test Ubuntu ubuntu_linux_debug please |
|
This was cherry-picked into #915 |
3 participants
This PR may require the presence of #915