Globalization Assert #780
Merged
Globalization Assert #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@akroshg Can you review this please ? |
Contributor
|
looks good to me. |
It is valid to have nullptr as a string as it will correctly throw a javascript Error that the Local is not well-formed.
| // will be rejected by globalization dll | ||
| IfFailThrowHr(GetWindowsGlobalizationLibrary(scriptContext)->WindowsCreateStringReference(languageTag, static_cast<UINT32>(wcslen(languageTag)), &hStringHdr, &hString)); | ||
| AnalysisAssert(hString); | ||
| if (hString == nullptr) |
Contributor
Author
There was a problem hiding this comment.
I added this because Prefast wouldn't let it pass.
For some reason the function IsWellFormed doesn't allow null in the signature, but supports it.
Contributor
Author
|
@akroshg is my additional change ok ? |
Contributor
|
Yes - infact this is better as we are future proofing ourselves in the case where IsWellFormed could not handle null itself. |
chakrabot
pushed a commit
that referenced
this pull request
Apr 13, 2016
Merge pull request #780 from Cellule:globalization Relax assert in Globalization IsWellFormed. It is valid to have nullptr as a string as it will correctly throw a javascript Error that the Local is not well-formed.
chakrabot
pushed a commit
that referenced
this pull request
Apr 13, 2016
Merge pull request #780 from Cellule:globalization Relax assert in Globalization IsWellFormed. It is valid to have nullptr as a string as it will correctly throw a javascript Error that the Local is not well-formed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax assert in Globalization IsWellFormed. It is valid to have nullptr as a string as it will correctly throw a javascript Error that the Local is not well-formed.
This change is