Await should only get the promise's constructor property once #6163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boingoing
approved these changes
Jun 14, 2019
chakrabot
pushed a commit
that referenced
this pull request
Jun 14, 2019
…ctor property once Merge pull request #6163 from zenparsing:promise-get-constructor Fixes #6162 Currently, `await` will trigger two gets for the operand's "constructor" property: once when doing `Promise.resolve` and then again in the call to `CreateThenPromise`. This change introduces `PerformPromiseThen`, a new function parallel to the spec's abstract operation of the same name, that takes a promise capability instead of creating a new one.
chakrabot
pushed a commit
that referenced
this pull request
Jun 24, 2019
Merge pull request #6172 from rhuanjl:asyncGeneratorFixes I missed async generator properties of objects when updating the parser in #5834 This PR: 1. fixes that omission enabling async generator properties of objects when async generators are enabled 2. adds tests for a couple of async generator syntax options that were not currently tested (including for point 1) 3. updates the async generator continue methods to use the new PerformPromiseThen from #6163 - this has no observable effect but improves internal consistency @zenparsing please could you take a look at this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6162
Currently,
awaitwill trigger two gets for the operand's "constructor" property: once when doingPromise.resolveand then again in the call toCreateThenPromise.This change introduces
PerformPromiseThen, a new function parallel to the spec's abstract operation of the same name, that takes a promise capability instead of creating a new one, along with:UnunsedPromiseCapabilityfunction, which can be optimized in the future for await scenarios.