Remove undefined functions in ScriptContext.h #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp: LeaveScriptStartCore, CleanEvalMapCache, AddFunctionBodyToPropIdMap. This patch removes them, since they are not used.
|
@dotnet-bot test Ubuntu shared_ubuntu_linux_release please |
MikeHolman
approved these changes
Sep 23, 2017
chakrabot
pushed a commit
that referenced
this pull request
Sep 23, 2017
Merge pull request #3634 from xiaoyinl:function_cleanup These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp: [LeaveScriptStartCore](https://github.com/Microsoft/ChakraCore/search?q=LeaveScriptStartCore), [CleanEvalMapCache](https://github.com/Microsoft/ChakraCore/search?q=CleanEvalMapCache), [AddFunctionBodyToPropIdMap](https://github.com/Microsoft/ChakraCore/search?q=AddFunctionBodyToPropIdMap). I wonder if we can remove them, since they are not used.
chakrabot
pushed a commit
that referenced
this pull request
Sep 23, 2017
…riptContext.h Merge pull request #3634 from xiaoyinl:function_cleanup These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp: [LeaveScriptStartCore](https://github.com/Microsoft/ChakraCore/search?q=LeaveScriptStartCore), [CleanEvalMapCache](https://github.com/Microsoft/ChakraCore/search?q=CleanEvalMapCache), [AddFunctionBodyToPropIdMap](https://github.com/Microsoft/ChakraCore/search?q=AddFunctionBodyToPropIdMap). I wonder if we can remove them, since they are not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp:
LeaveScriptStartCore, CleanEvalMapCache, AddFunctionBodyToPropIdMap.
I wonder if we can remove them, since they are not used.