Fix Issue #3368: Symbol.species.toString() shouldn't have bracket around the name #3412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like you need to update a few baselines to reflect this change as well. |
Contributor
Author
|
@MSLaguana The accessor function name needs to have the bracket. toStringTag already have similar pattern and defined propertyId for the function name with [] for all the symbols.. So I updated it to create the accessor with the appropriate name. The debugger baseline will need to be updated :( |
…bracket around the name
akroshg
reviewed
Jul 21, 2017
|
|
||
| void JavascriptLibrary::AddSpeciesAccessorsToLibraryObject(DynamicObject* object, FunctionInfo * getterFunctionInfo) | ||
| { | ||
| if (scriptContext->GetConfig()->IsES6SpeciesEnabled()) |
Contributor
There was a problem hiding this comment.
Nit: species have been enabled since th2. We could get rid of this check.
Contributor
Author
There was a problem hiding this comment.
We probably can do a clean up for all the enabled language feature later.
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Jul 21, 2017
…houldn't have bracket around the name Merge pull request #3412 from curtisman:fix3368
chakrabot
pushed a commit
that referenced
this pull request
Jul 21, 2017
…String() shouldn't have bracket around the name Merge pull request #3412 from curtisman:fix3368
chakrabot
pushed a commit
that referenced
this pull request
Jul 21, 2017
…ol.species.toString() shouldn't have bracket around the name Merge pull request #3412 from curtisman:fix3368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.