Bugfix:OS5553123:Freeze while comparing valueOf()-injected null #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
| dblRight = JavascriptConversion::ToNumber(aRight, scriptContext); | ||
| break; | ||
| case TypeIds_Boolean: | ||
| case TypeIds_Null: |
Contributor
There was a problem hiding this comment.
should handle the undefined and symbol cases here.
Author
There was a problem hiding this comment.
Good point. Updated in latest rev.
Contributor
|
Looks good. |
Contributor
|
LGTM, signing off. |
Contributor
|
Actually, can we get tests for the undefined/symbol case? otherwise looks good. |
| } | ||
|
|
||
| testRelationalComparison(null); | ||
| testRelationalComparison(undefined); |
Author
There was a problem hiding this comment.
@tcare, unit test covers 'undefined' and Symbol here.
Contributor
There was a problem hiding this comment.
Ah saw the wrong revision. thanks :)
Chakra implementation of Abstract Relational Comparison operation fails to
handle 'null'. Specifically, it cause a browser tab to freeze when a comparison ("<")
is done with the left value being 'null' injected by valueOf() call through a prototype.
Add 'null' checking to fix this problem.
Add unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix:OS5553123:Freeze while comparing valueOf()-injected null
Chakra implementation of Abstract Relational Comparison operation fails to
handle 'null'. Specifically, it cause a browser tab to freeze when a comparison ("<")
is done with the left value being 'null' injected by valueOf() call through a prototype.
Add 'null' checking to fix this problem.
Add unit test.