Uint32 constant #295
Merged
Uint32 constant #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LouisLaf, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
|
LGTM. Opnd typing in this function is a bit confusing though. Can you change the CompareBranch a few lines down to use TyUint32? JavascriptString::m_charLength is uint32 (and we're doing unsigned compare), so would help clarity. |
LouisLaf
force-pushed
the
intconst
branch
2 times, most recently
from
03a7217 to
d22a82c
Compare
Properly cast to uint32 a TyUint32 offset to avoid having it sign extended to 64bit on x64.
chakrabot
pushed a commit
that referenced
this pull request
Feb 29, 2016
Merge pull request #295 from LouisLaf:intconst Properly cast to uint32 a TyUint32 offset to avoid having it sign extended to 64bit on x64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly cast to uint32 a TyUint32 offset to avoid having it sign extended to 64bit on x64.