reduce property record storage on JIT server #1738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHolman
force-pushed
the
proprecord
branch
from
4d8b1a8 to
b409ca8
Compare
leirocks
reviewed
Oct 13, 2016
| unsigned int newRecordCount; | ||
| unsigned int newPropertyCount; | ||
| [size_is(reclaimedPropertyCount)] int * reclaimedPropertyIdArray; | ||
| [size_is(newRecordCount)] PropertyRecordIDL ** newRecordArray; |
Contributor
There was a problem hiding this comment.
PropertyRecordIDL [](start = 30, length = 17)
remove PropertyRecordIDL definition?
leirocks
reviewed
Oct 13, 2016
lib/Backend/Func.h
Outdated
|
|
||
| ThreadContext * GetInProcThreadContext() const | ||
| { | ||
| if (JITManager::GetJITManager()->IsOOPJITEnabled()) |
Contributor
There was a problem hiding this comment.
JITManager::GetJITManager()->IsOOPJITEnabled() [](start = 12, length = 46)
change to assertion only?
leirocks
reviewed
Oct 13, 2016
| propertySym->m_stackSym->Dump(flags, valueType); | ||
| Js::PropertyRecord const* fieldName = propertySym->m_func->GetThreadContextInfo()->GetPropertyRecord(propertySym->m_propertyId); | ||
| Output::Print(_u("->%s"), fieldName->GetBuffer()); | ||
| if (JITManager::GetJITManager()->IsOOPJITEnabled()) |
Contributor
|
|
MikeHolman
force-pushed
the
proprecord
branch
3 times, most recently
from
1abb8a1 to
2eabdc7
Compare
MikeHolman
force-pushed
the
proprecord
branch
from
2eabdc7 to
afd7de4
Compare
chakrabot
pushed a commit
that referenced
this pull request
Oct 18, 2016
Merge pull request #1738 from MikeHolman:proprecord We only really need to know if a property ID is numeric, rest of property record was only being used for debug output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only really need to know if a property ID is numeric, rest of property record was only being used for debug output.