Do not reuse by resetting the JavascriptStaticEnumerator in the ForInObjectEnumerator #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ObjectEnumerator Even if the type match, the object may have change to have array index, producing wrong result. Since we now have an instance of the DynamicObjectPropertyEnumerator in the JavascriptStaticEnumerator already, reset doesn't really gain us much. So just remove it.
Contributor
Author
|
@rajatd please review. |
Collaborator
|
|
agarwal-sandeep
approved these changes
Sep 30, 2016
chakrabot
pushed a commit
that referenced
this pull request
Sep 30, 2016
…icEnumerator in the ForInObjectEnumerator Merge pull request #1670 from curtisman:fix Even if the type match, the object may have change to have array index, producing wrong result. Since we now have an instance of the DynamicObjectPropertyEnumerator in the JavascriptStaticEnumerator already, reset doesn't really gain us much. So just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the type match, the object may have change to have array index, producing wrong result.
Since we now have an instance of the DynamicObjectPropertyEnumerator in the JavascriptStaticEnumerator already, reset doesn't really gain us much. So just remove it.