Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the ByteCodeUse and Cm/Br(Sr)?[GL][te] instructions in the unsigned compare peep #1636

Merged
merged 2 commits into from
Sep 26, 2016

Conversation

Penguinwizzard
Copy link
Contributor

This helps avoid situations in which the arguments to the compare op
would get optimized out too aggressively, and are then unavailable in
exceptional cases.

@msftclas
Copy link

Hi @Penguinwizzard, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Derek Morris). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@Penguinwizzard
Copy link
Contributor Author

Fixes #1627. @rajatd please review.

@rajatd
Copy link
Contributor

rajatd commented Sep 26, 2016

:shipit:

…signed compare peep

This helps avoid situations in which the arguments to the compare op
would get optimized out too aggressively, and are then unavailable in
exceptional cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants