cross-platform: Fix external build break and add native testing #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
force-pushed
the
fix_lnx_break
branch
7 times, most recently
from
6737c3b to
abb40a6
Compare
Collaborator
Author
|
@dotnet-bot test Windows x64_release please |
Collaborator
Author
|
@dotnet-bot test Windows arm_release please |
Collaborator
Author
|
@dotnet-bot test Windows x86_release please |
obastemur
force-pushed
the
fix_lnx_break
branch
5 times, most recently
from
dcb61fe to
d769457
Compare
We have been keep breaking the native sample project. Fixing the break and adding a native test to make sure we do not break it again
obastemur
force-pushed
the
fix_lnx_break
branch
from
d769457 to
172e159
Compare
Contributor
|
|
Collaborator
Author
|
@digitalinfinity Thanks for the review |
chakrabot
pushed a commit
that referenced
this pull request
Aug 25, 2016
… add native testing Merge pull request #1479 from obastemur:fix_lnx_break We've been keep breaking the native sample project. Fixing the break and adding a native test to make sure we do not break it again new WScript.Platform members : 'LINK_TYPE' and 'BINARY_PATH'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been keep breaking the native sample project.
Fixing the break and adding a native test to make sure we do not break it again
new WScript.Platform members : 'LINK_TYPE' and 'BINARY_PATH'