Wasm: Compilation exception message bugfix #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@MikeHolman @commonlisp Can you please review ? |
Contributor
|
|
Cellule
added a commit
that referenced
this pull request
Aug 16, 2016
Merge pull request #1447 from Cellule:wasm/error Fix bug in the Wasm Exception error message memory handling. The memory for the string was being freed to soon by the destructor of the c++ exception. Which caused the next SysAllocString to allocate a different string at the same pointer of the previous wasm message. The string's memory needs to be handled manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in the Wasm Exception error message memory handling.
The memory for the string was being freed to soon by the destructor of the c++ exception. Which caused the next SysAllocString to allocate a different string at the same pointer of the previous wasm message.
The string's memory needs to be handled manually.
This change is