Update for TTD - Node+VSCode, bug fixes, x-plat #1338
Conversation
|
@dilijev @jianchun @agarwal-sandeep @digitalinfinity @Yongqu please review |
| #endif | ||
|
|
||
| if (errorCode == JsNoError) | ||
| if(errorCode == JsNoError) |
There was a problem hiding this comment.
if( [](start = 8, length = 3)
nit: preferred style throughout our codebase is if ( (with a space).
|
@jianchun @digitalinfinity There is also a change to runtests.py that forces it to a single thread. I added a tag "sequential" to rl that allows the tests in a directory to be run sequentially and in-order for a directory but runtests does not recognize this flag yet. |
bin/ch/ch.cpp
Outdated
|
|
||
| ChakraRTInterface::JsTTDMoveToTopLevelEvent(snapEventTime, nextEventTime); | ||
| ChakraRTInterface::JsTTDPrepContextsForTopLevelEventMove(chRuntime, needFreshCtxs); | ||
| ChakraRTInterface::JsTTDMoveToTopLevelEvent(moveMode, snapEventTime, nextEventTime); |
There was a problem hiding this comment.
Error checking? You can use the macros defined in bin\ch\stdafx.h.
| #if !ENABLE_TTD_DEBUGGING | ||
| return JsErrorCategoryUsage; | ||
| #else | ||
| JsrtContext *currentContext = JsrtContext::GetCurrent(); |
There was a problem hiding this comment.
We expect a valid context here so this should be inside ContextAPIWrapper. In other APIs as well, since we are getting current context and there is no check to validate that.
|
@dotnet-bot |
|
@dotnet-bot test Windows arm_debug please |
Merge pull request #1338 from mrkmarron:ttdNodeUpdate -Changes needed for debugging with Node & VSCode (see PR #1215). - Various bug fixes -Perf in interperter loop -Break in release ch -DisableJIT issues (Fixes #1244) - x-plat types & API defs in JsRT - x-plat host support and all TTD tests in Linux
7 participants
-Changes needed for debugging with Node & VSCode (see PR #1215).
-Perf in interperter loop
-Break in release ch
-DisableJIT issues (Fixes Investigate whether TTBasic and TTExecuteBasic tests could be run in DisableJIT mode. #1244)