Skip to content

No way to pass user data to thread service callback #6957

Open
@zopsicle

Description

@zopsicle

Customarily, callbacks take an additional user data parameter so that closures can be used as callbacks. This is the case with, for example, JsMemoryAllocationCallback. However, JsThreadServiceCallback takes no such parameter (do not confuse this with its callbackState parameter, which is not user data rather engine-provided data for the work item callback).

Ideally the API would be:

typedef bool (CALLBACK *JsThreadServiceCallback)(
    _In_ JsBackgroundWorkItemCallback workItemCallback,
    _In_opt_ void *workItemCallbackState,
    _In_opt_ void *threadServiceCallbackState
);

STDAPI_(JsErrorCode) JsCreateRuntime(
    _In_ JsRuntimeAttributes attributes,
    _In_opt_ JsThreadServiceCallback threadService,
    _In_opt_ void *threadServiceCallbackState
    _Out_ JsRuntimeHandle *runtime
);

where the runtime would pass threadServiceCallbackState to threadService whenever it’s called.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions