JSRT: JsDeleteIndexedProperty does not tell successful or not

[jianchun]

JsDeleteIndexedProperty API does not tell if the deletion is successful or not, unlike JsDeleteProperty which returns that info in "result". The former also misses "useStrictRules" flag which exists in the later.

JsDeleteIndexedProperty(JsValueRef object, JsValueRef index)

JsDeleteProperty(JsValueRef object, JsPropertyIdRef propertyId,
                 bool useStrictRules,
                 JsValueRef *result)

These 2 APIs should be comparable and consistent.

[liminzhu]

Interesting....Before we change the API shape, does the JsErrorCode returned show any indication of successful/failed deletion?

[jianchun]

Interesting....Before we change the API shape, does the JsErrorCode returned show any indication of successful/failed deletion?

No.

I thought we couldn't change API shape due to compat requirement?

[liminzhu]

Right. Any proposal on how to fix it?

[m3talsmith]

So are we saying that a return breaks API compat? If previous code discarded returns (or did not expect, and hence did not capture, returns), does a return matter?

[liminzhu]

Return in the sense of an extra out-param like JsValueRef *result for JsDeleteProperty, just like the JavaScript detele operator would return true/false. Change in that fashion would cause compile error.

[xiaoyinl]

How about creating a new API JsDeleteIndexedPropertyWithResult or JsDeleteIndexedPropertyV2?

[SivaDotRender]

has @xiaoyinl been assigned to this issue or could I attempt to send in a PR for this?

[xiaoyinl]

@SivaDotRender I am not assigned to this issue.