Skip to content

Commit

Permalink
[MERGE #3634 @xiaoyinl] Remove undefined functions in ScriptContext.h
Browse files Browse the repository at this point in the history
Merge pull request #3634 from xiaoyinl:function_cleanup

These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp:
[LeaveScriptStartCore](https://github.com/Microsoft/ChakraCore/search?q=LeaveScriptStartCore), [CleanEvalMapCache](https://github.com/Microsoft/ChakraCore/search?q=CleanEvalMapCache), [AddFunctionBodyToPropIdMap](https://github.com/Microsoft/ChakraCore/search?q=AddFunctionBodyToPropIdMap).

I wonder if we can remove them, since they are not used.
  • Loading branch information
MikeHolman committed Sep 23, 2017
2 parents 2e48b60 + b966a9d commit 9753783
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions lib/Runtime/Base/ScriptContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,6 @@ namespace Js
char16 const * url;

void PrintStats();
BOOL LeaveScriptStartCore(void * frameAddress, bool leaveForHost);

void InternalClose();

Expand Down Expand Up @@ -1065,7 +1064,6 @@ namespace Js

template <typename TCacheType>
void CleanDynamicFunctionCache(TCacheType* cacheType);
void CleanEvalMapCache(Js::EvalCacheTopLevelDictionary * cacheType);

template <class TDelegate>
void MapFunction(TDelegate mapper);
Expand Down Expand Up @@ -1201,7 +1199,6 @@ namespace Js
void SetFastDOMenabled();
BOOL VerifyAlive(BOOL isJSFunction = FALSE, ScriptContext* requestScriptContext = nullptr);
void VerifyAliveWithHostContext(BOOL isJSFunction, HostScriptContext* requestHostScriptContext);
void AddFunctionBodyToPropIdMap(FunctionBody* body);

void BindReference(void* addr);

Expand Down

0 comments on commit 9753783

Please sign in to comment.