Skip to content

Conversation

@jiangwel
Copy link
Collaborator

@jiangwel jiangwel commented Feb 5, 2026

  • 为 Azure OpenAI 配置添加 AzureModelMapperFunc 以支持自定义模型映射
  • 在百炼模型列表中添加 embedding 和 rerank 模型
  • 更新前端 ModelModal 组件,允许 Azure OpenAI、火山引擎和百炼的嵌入/重排序模型手动输入模型名称
  • 在文档中更新支持的提供商列表并添加运行示例环境的说明
  • 添加测试用例验证 Azure OpenAI 配置构建逻辑

- 为 Azure OpenAI 配置添加 AzureModelMapperFunc 以支持自定义模型映射
- 在百炼模型列表中添加 embedding 和 rerank 模型
- 更新前端 ModelModal 组件,允许 Azure OpenAI、火山引擎和百炼的嵌入/重排序模型手动输入模型名称
- 在文档中更新支持的提供商列表并添加运行示例环境的说明
- 添加测试用例验证 Azure OpenAI 配置构建逻辑
@jiangwel
Copy link
Collaborator Author

jiangwel commented Feb 5, 2026

@coderabbitai full review

@jiangwel
Copy link
Collaborator Author

jiangwel commented Feb 5, 2026

@copilot review

@jiangwel
Copy link
Collaborator Author

jiangwel commented Feb 5, 2026

@monkeycodeai review

@jiangwel
Copy link
Collaborator Author

jiangwel commented Feb 5, 2026

@MonkeyCode-AI review

@monkeycode-ai
Copy link

monkeycode-ai bot commented Feb 5, 2026

MonkeyCode-AI 正在分析任务...

Copy link

@monkeycode-ai monkeycode-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我是 MonkeyCode AI 编程助手,你可以在 GitHub 仓库的 PR 中 at @MonkeyCode-AI 来呼唤我。

任务执行细节请参考: https://monkeycode-ai.com/tasks/public?id=5e3dc45a-6659-4a14-8086-32dde6fadd55

代码审查结果

整体变更围绕“允许部分厂商手动输入 embedding/rerank 模型名 + Azure 默认提供模型映射函数”展开,方向正确,但存在 BaiLian rerank BaseURL 末尾 # 与前端硬编码重复、以及 Makefile dev 任务健壮性不足等问题,建议修正后合入。

✨ 代码亮点

  • 为 Azure OpenAI 增加 AzureModelMapperFunc 并补充单测,覆盖了配置构建关键路径
  • 前端允许特定厂商在 embedding/rerank 场景手动输入模型名,增强了兼容性
  • 文档补充 make dev 一键运行示例环境说明,降低上手成本
🚨 Critical ⚠️ Warning 💡 Suggestion
0 1 0

Comment on lines +135 to +136
{ModelName: "gte-rerank", Object: "model", Provider: consts.ModelProviderBaiLian, ModelType: consts.ModelTypeRerank, BaseURL: "https://dashscope.aliyuncs.com/api/v1/services/rerank/text-rerank/text-rerank#"},
{ModelName: "qwen3-rerank", Object: "model", Provider: consts.ModelProviderBaiLian, ModelType: consts.ModelTypeRerank, BaseURL: "https://dashscope.aliyuncs.com/api/v1/services/rerank/text-rerank/text-rerank#"},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

⚠️ BaiLian rerank BaseURL 末尾包含 #,疑似无效/易导致拼接或请求异常

新增的 BaiLian rerank 模型 BaseURL 使用了 .../text-rerank#。URL fragment(# 后内容)不会被发送到服务端,且如果后续代码对 BaseURL 进行 path/query 拼接,可能造成不可预期行为。前端也同样硬编码了该 #(见 ModelModal.tsx),进一步放大风险。

建议: 确认该 # 是否有特殊语义;若无,建议移除,统一为可直接请求的服务端地址,并避免前后端分别硬编码不同/奇怪的 BaseURL。

Suggested change
{ModelName: "gte-rerank", Object: "model", Provider: consts.ModelProviderBaiLian, ModelType: consts.ModelTypeRerank, BaseURL: "https://dashscope.aliyuncs.com/api/v1/services/rerank/text-rerank/text-rerank#"},
{ModelName: "qwen3-rerank", Object: "model", Provider: consts.ModelProviderBaiLian, ModelType: consts.ModelTypeRerank, BaseURL: "https://dashscope.aliyuncs.com/api/v1/services/rerank/text-rerank/text-rerank#"},
{ModelName: "gte-rerank", Object: "model", Provider: consts.ModelProviderBaiLian, ModelType: consts.ModelTypeRerank, BaseURL: "https://dashscope.aliyuncs.com/api/v1/services/rerank/text-rerank/text-rerank"},
{ModelName: "qwen3-rerank", Object: "model", Provider: consts.ModelProviderBaiLian, ModelType: consts.ModelTypeRerank, BaseURL: "https://dashscope.aliyuncs.com/api/v1/services/rerank/text-rerank/text-rerank"},

@jiangwel jiangwel merged commit a472fa5 into main Feb 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant