Skip to content

chore: validate dependent attestation in referrer endpoint - #745

Merged
migmartri merged 3 commits into
chainloop-dev:mainfrom
migmartri:validate-attestation-graph
May 3, 2024
Merged

chore: validate dependent attestation in referrer endpoint#745
migmartri merged 3 commits into
chainloop-dev:mainfrom
migmartri:validate-attestation-graph

Conversation

@migmartri

Copy link
Copy Markdown
Member

This patch updates the ingestion process for the referrer graph to make sure that attached attestations node exists in advance.

Closes #735

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested review from javirln and jiparis May 3, 2024 10:11

@jiparis jiparis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks good to me.

migmartri added 2 commits May 3, 2024 12:20
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri merged commit aee5e72 into chainloop-dev:main May 3, 2024
@migmartri
migmartri deleted the validate-attestation-graph branch May 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate that the dependent attestation exist before we store the referrer

2 participants