Skip to content

feat(cli): Workflow run can receive a status flag - #723

Merged
javirln merged 6 commits into
chainloop-dev:mainfrom
javirln:feat/718
Apr 29, 2024
Merged

feat(cli): Workflow run can receive a status flag#723
javirln merged 6 commits into
chainloop-dev:mainfrom
javirln:feat/718

Conversation

@javirln

@javirln javirln commented Apr 29, 2024

Copy link
Copy Markdown
Member

Added a status flag with the possible values that are verified on the actions package. Passing the flag works as expected:

Ref: #718

$chainloop wf workflow-run ls --status FAILED
┌──────────────────────────────────────┬────────────────────────────────┬───────┬─────────────────────┬────────┐
│ ID                                   │ WORKFLOW                       │ STATE │ CREATED AT          │ RUNNER │
├──────────────────────────────────────┼────────────────────────────────┼───────┼─────────────────────┼────────┤
│ 56220bdc-5e28-4e92-b955-c8ffa25cca6f │ chainloop/chainloop-codeql     │ error │ 29 Apr 24 08:28 UTC │ GitHub │
│ d21220ae-907f-40af-99ac-0d88af1636e7 │ chainloop/chainloop-codeql     │ error │ 29 Apr 24 08:10 UTC │ GitHub │
│ ab3ea91e-f1b9-4a24-ba06-34c3cf8c6bf4 │ chainloop/chainloop-codeql     │ error │ 29 Apr 24 07:49 UTC │ GitHub │
│ 4414888d-0eb2-44cf-b960-38078d995d39 │ chainloop/chainloop-codeql     │ error │ 29 Apr 24 07:42 UTC │ GitHub │
│ ad00cd05-2593-44b7-a81b-eb066297c5dc │ chainloop/chainloop-codeql     │ error │ 29 Apr 24 07:36 UTC │ GitHub │
│ f09ff2ad-18a7-49e9-803a-7d4b91a39980 │ chainloop/chainloop-codeql     │ error │ 29 Apr 24 07:23 UTC │ GitHub │
│ aa6b895b-0e35-42c7-88be-aec8e7d50177 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:33 UTC │ GitHub │
│ e9227628-e892-4f69-a369-038175775bb1 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:30 UTC │ GitHub │
│ 6992087d-3224-4ca0-9056-8d8995f390f8 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:26 UTC │ GitHub │
│ 93d4bdf9-163f-4f25-9f98-5157386700f3 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:20 UTC │ GitHub │
│ 1411b1a3-41fc-4edb-80ea-c98076bba830 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:17 UTC │ GitHub │
│ 344ffb1d-62b6-454b-a0d8-b15cb10d06b8 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:14 UTC │ GitHub │
│ 8f05b1f1-c9ae-4597-9533-438328b54485 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:13 UTC │ GitHub │
│ 70b23075-493a-45f6-b8f2-6af7a474456c │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 14:02 UTC │ GitHub │
│ e87ac523-cc3e-4a07-82f8-c499541ae04b │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 13:59 UTC │ GitHub │
│ bd66e30b-328b-48d5-b1a9-5f6e1c674a63 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 13:49 UTC │ GitHub │
│ 86db597a-1bfc-419e-8713-0c26d42917c9 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 13:33 UTC │ GitHub │
│ e5c4a599-f82e-4e39-9cbc-e29bbde6272c │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 12:22 UTC │ GitHub │
│ 04e1fb16-471b-4fff-98c0-bf3dadcf9b52 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 12:02 UTC │ GitHub │
│ 30851df8-ce8d-4c0f-9dad-8ca65c81a648 │ chainloop/chainloop-scorecards │ error │ 26 Apr 24 11:42 UTC │ GitHub │
└──────────────────────────────────────┴────────────────────────────────┴───────┴─────────────────────┴────────┘
Pagination options 

--next MjAyNC0wNC0yNlQxMTo0MjowMi4wNTE5OTJaLDMwODUxZGY4LWNlOGQtNGMwZi05ZGFkLThjYTY1YzgxYTY0OA==

Process finished with the exit code 0

Listing the possible values:

$chainloop wf workflow-run ls --help
List workflow runs

Usage:
  chainloop workflow workflow-run list [flags]

Aliases:
  list, ls

Flags:
      --full              full report
  -h, --help              help for list
      --limit int         number of items to show (default 20)
      --next string       cursor to load the next page
      --status string     filter by workflow run status: [FAILED EXPIRED CANCELLED INITIALIZED SUCCEEDED]
      --workflow string   workflow ID

Global Flags:
      --artifact-cas string    URL for the Artifacts Content Addressable Storage (CAS) (default "api.cas.chainloop.dev:443")
  -c, --config string          Path to an existing config file (default is $HOME/.config/chainloop/config.toml)
      --control-plane string   URL for the Control Plane API (default "api.cp.chainloop.dev:443")
      --debug                  Enable debug/verbose logging mode
  -i, --insecure               Skip TLS transport during connection to the control plane
  -o, --output string          Output format, valid options are json and table (default "table")
  -t, --token string           API token. NOTE: Alternatively use the env variable CHAINLOOP_API_TOKEN

Process finished with the exit code 0

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
javirln requested review from jiparis and migmartri April 29, 2024 09:45
@javirln javirln self-assigned this Apr 29, 2024
javirln added 2 commits April 29, 2024 11:53
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Comment thread app/cli/internal/action/workflow_run_list.go Outdated

@migmartri migmartri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about getting the list of available options from the proto enum instead.

Thanks!

Comment thread app/cli/internal/action/workflow_run_list_test.go Outdated
Comment thread app/cli/internal/action/workflow_run_list_test.go Outdated
javirln added 2 commits April 29, 2024 12:30
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Comment thread app/cli/internal/action/workflow_run_list.go

@migmartri migmartri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about implementing yourself the method that returns the list of available options. Other than that LGTM

Comment thread app/cli/cmd/workflow_workflow_run_list.go Outdated
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Comment thread app/cli/cmd/workflow_workflow_run_list.go
@javirln
javirln merged commit b7a0cb9 into chainloop-dev:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants