feat(cli): Workflow run can receive a status flag - #723
Merged
Conversation
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri
reviewed
Apr 29, 2024
migmartri
approved these changes
Apr 29, 2024
migmartri
left a comment
Member
There was a problem hiding this comment.
See my comment about getting the list of available options from the proto enum instead.
Thanks!
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
reviewed
Apr 29, 2024
jiparis
approved these changes
Apr 29, 2024
migmartri
approved these changes
Apr 29, 2024
migmartri
left a comment
Member
There was a problem hiding this comment.
See my comment about implementing yourself the method that returns the list of available options. Other than that LGTM
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri
reviewed
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a status flag with the possible values that are verified on the
actionspackage. Passing the flag works as expected:Ref: #718
Listing the possible values: