Skip to content

fix(ci): Use chainloop action on scorecard pipeline - #715

Merged
javirln merged 2 commits into
mainfrom
fix/platform-706-job
Apr 26, 2024
Merged

fix(ci): Use chainloop action on scorecard pipeline#715
javirln merged 2 commits into
mainfrom
fix/platform-706-job

Conversation

@javirln

@javirln javirln commented Apr 26, 2024

Copy link
Copy Markdown
Member

Leverages the use of chainloop action rather the manual steps so it complies with ossf/scorecard constraints.

@javirln
javirln requested review from jiparis and migmartri April 26, 2024 12:45

@migmartri migmartri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be tested on PR?

@javirln

javirln commented Apr 26, 2024

Copy link
Copy Markdown
Member Author

could it be tested on PR?

We could test that the use of the action is correct but not the production checks. I'll run it.

@javirln javirln self-assigned this Apr 26, 2024
@javirln
javirln marked this pull request as draft April 26, 2024 13:14
Comment thread .github/workflows/scorecards.yml Fixed
Comment thread .github/workflows/scorecards.yml Fixed
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
javirln force-pushed the fix/platform-706-job branch from d584a82 to 31dbb7f Compare April 26, 2024 14:45
@javirln
javirln marked this pull request as ready for review April 26, 2024 14:45
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javirln
javirln merged commit 9ff4415 into main Apr 26, 2024
@javirln
javirln deleted the fix/platform-706-job branch April 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants