fix(scorecards): Move env variable to individual steps - #713
Merged
Conversation
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scorecard action is complaining about top level env vars in a production workflow, aka: a workflow running on the default branch on the repository.
2024/04/26 11:42:48 error sending scorecard results to webapp: http response 400, status: 400 Bad Request, error: {"code":400,"message":"workflow verification failed: scorecard job contains env vars, see https://github.com/ossf/scorecard-action#workflow-restrictions for details."} 2024/04/26 11:42:48 retrying in 1s... 2024/04/26 11:42:50 error sending scorecard results to webapp: http response 400, status: 400 Bad Request, error: {"code":400,"message":"workflow verification failed: scorecard job contains env vars, see https://github.com/ossf/scorecard-action#workflow-restrictions for details."} 2024/04/26 11:42:50 retrying in 3s... 2024/04/26 11:42:53 error sending scorecard results to webapp: http response 400, status: 400 Bad Request, error: {"code":400,"message":"workflow verification failed: scorecard job contains env vars, see https://github.com/ossf/scorecard-action#workflow-restrictions for details."} 2024/04/26 11:42:53 retrying in 10s... 2024/04/26 11:43:03 error processing signature: error sending scorecard results to webapp: http response 400, status: 400 Bad Request, error: {"code":400,"message":"workflow verification failed: scorecard job contains env vars, see https://github.com/ossf/scorecard-action#workflow-restrictions for details."}To overrun this, let's move the env to the steps that needs them, removing the top level dependency.
Refers to #706