Skip to content

feat(docs-deploy): Bump version of chainloop action to perform checkout before init - #708

Merged
javirln merged 1 commit into
chainloop-dev:mainfrom
javirln:feat/platform-705
Apr 26, 2024
Merged

feat(docs-deploy): Bump version of chainloop action to perform checkout before init#708
javirln merged 1 commit into
chainloop-dev:mainfrom
javirln:feat/platform-705

Conversation

@javirln

@javirln javirln commented Apr 26, 2024

Copy link
Copy Markdown
Member

This PR leverages the changes introduced in chainloop-dev/labs#6 so all needed git repository information is being retrieved before the attestation init is being done.

Closes #705

…ut before init

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
javirln requested review from jiparis and migmartri April 26, 2024 10:15
@javirln javirln self-assigned this Apr 26, 2024
api_token: ${{ secrets.CHAINLOOP_ROBOT_ACCOUNT_DOCS_RELEASE }}
with:
chainloop_labs_branch: 7f4de29435dc009326587051f507d2cd8c77d28b
chainloop_labs_branch: d0298b552d20d018e4ec39a28661d225bab40057

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why we need to maintain a branch here? cc/ @danlishka

@danlishka danlishka Apr 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to know which version of labs you want to install. In the past, this was a flexibility I needed when building functions that work across GitLab, GitHub, and Azure DevOps.

@migmartri migmartri Apr 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't pinning the reusable workflow version be enough?

api_token: ${{ secrets.CHAINLOOP_ROBOT_ACCOUNT_DOCS_RELEASE }}
with:
chainloop_labs_branch: 7f4de29435dc009326587051f507d2cd8c77d28b
chainloop_labs_branch: d0298b552d20d018e4ec39a28661d225bab40057

@danlishka danlishka Apr 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to know which version of labs you want to install. In the past, this was a flexibility I needed when building functions that work across GitLab, GitHub, and Azure DevOps.

@javirln
javirln merged commit 8084706 into chainloop-dev:main Apr 26, 2024
@javirln
javirln deleted the feat/platform-705 branch April 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

link docs release process with chainloop release during attestation

3 participants