feat(materials): Helm Chart material support - #689
Merged
Conversation
javirln
changed the title
javirln
marked this pull request as ready for review
April 24, 2024 08:19
Member
|
Awesome @javirln As you can see, the CI is complaining that the DCO is not completed. This means that you are not committing with the signed-off line I'd suggest that you squash all your commits and amend it to have the signed off. Happy to help if you have any questions Thanks |
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri
approved these changes
Apr 24, 2024
jiparis
reviewed
Apr 24, 2024
jiparis
reviewed
Apr 24, 2024
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Member
|
Something that I do when I need to tackle some feedback, is to put the PR in draft, to signal that's not ready yet. You might want to do the same |
javirln
marked this pull request as draft
April 24, 2024 09:56
javirln
marked this pull request as ready for review
April 24, 2024 10:03
Member
|
Looks good to me! Feel free to merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Helm Charts files as material types. These get validated before they are uploaded to the CAS and attached to the attestation process.
The validations checks for the following:
Charts.yamlandvalues.yamlfiles are present on the uncompressed directory and it's a valid YAML file.Closes #684