Skip to content

feat(controlplane): add extra info to discovery endpoint - #641

Merged
migmartri merged 4 commits into
chainloop-dev:mainfrom
migmartri:add-new-metadata-to-workflows
Apr 1, 2024
Merged

feat(controlplane): add extra info to discovery endpoint#641
migmartri merged 4 commits into
chainloop-dev:mainfrom
migmartri:add-new-metadata-to-workflows

Conversation

@migmartri

@migmartri migmartri commented Mar 29, 2024

Copy link
Copy Markdown
Member

The main goal of this patch is to add additional information to the discovery endpoint when the nodes are attestations kinds.

So now, the metadata struct contains the team, project and organization name. To achieve this I've added the organization to the attested object metadata as well.

{
   "digest": "sha256:05251995ddb3380ce3a719d374a18cc9ab5e2a48852ee96b0361ef329447b801",
   "kind": "ATTESTATION",
   "downloadable": true,
   "public": false,
   "createdAt": "2024-03-29T21:51:12.852033Z",
   "references": [
      {
         "digest": "sha1:d6e16f863e47c0a75e812faa870c27d5c600faa4",
         "kind": "GIT_HEAD_COMMIT",
         "downloadable": false,
         "public": false,
         "createdAt": "2024-03-29T21:29:40.092477Z",
         "references": []
      }
   ],
   "metadata": {
      "name": "foo-b2az",
      "organization": "wizardly-mccarthy-3002",
      "project": "bar",
      "team": "my-team"
   }
}

refs #498

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested a review from danlishka March 29, 2024 21:54
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri
migmartri merged commit 27e1a74 into chainloop-dev:main Apr 1, 2024
@migmartri
migmartri deleted the add-new-metadata-to-workflows branch April 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants