Skip to content

feat(controlplane): unique workflow name and formatted project - #605

Merged
migmartri merged 4 commits into
chainloop-dev:mainfrom
migmartri:workflow-name-unique-2
Mar 12, 2024
Merged

feat(controlplane): unique workflow name and formatted project#605
migmartri merged 4 commits into
chainloop-dev:mainfrom
migmartri:workflow-name-unique-2

Conversation

@migmartri

@migmartri migmartri commented Mar 12, 2024

Copy link
Copy Markdown
Member

Similarly to #601 but applied to workflows, it

  • Makes both workflow names and project RFC 1123 compliant
  • Make sure that the workflow name is unique at the organization level
  • migrates the existing workflow names and projects to meet 1

Closes #602

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri changed the title feat: update workflow name and org feat(controlplane): unique workflow name and formatted project Mar 12, 2024
@migmartri
migmartri marked this pull request as ready for review March 12, 2024 15:53
@migmartri
migmartri requested a review from danlishka March 12, 2024 15:53
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@migmartri
migmartri merged commit 01ad13a into chainloop-dev:main Mar 12, 2024
@migmartri
migmartri deleted the workflow-name-unique-2 branch March 12, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow names uniqueness/format handling

2 participants