Skip to content

feat(dagger): sync method - #599

Merged
migmartri merged 1 commit into
chainloop-dev:mainfrom
migmartri:add-sync-method
Mar 12, 2024
Merged

feat(dagger): sync method#599
migmartri merged 1 commit into
chainloop-dev:mainfrom
migmartri:add-sync-method

Conversation

@migmartri

Copy link
Copy Markdown
Member

Creates a Sync method that forces the execution of the DAG. This is important so we can make sure Init doesn't wait until push to create an instance of a run in the controlplane for example.

This is a workaround at not being able to do

att, err := chainloop.Init(...).Sync(ctx)

which is what the Container/File/Directory core primitives can do.

More context here: https://discord.com/channels/707636530424053791/1215428709910188133/1216885885279146074

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested a review from danlishka March 12, 2024 08:53

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri
migmartri merged commit 1c059f7 into chainloop-dev:main Mar 12, 2024
@migmartri
migmartri deleted the add-sync-method branch March 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants