Let's take the Dagger module to the next level :) - #581
Merged
Conversation
shykes
force-pushed
the
dagger-improvements
branch
from
March 8, 2024 07:16
d45ea67 to
cc87285
Compare
migmartri
reviewed
Mar 8, 2024
Member
There was a problem hiding this comment.
This is very cool, I can see where this is going :)
I added some feedback, but I don't want to block you with all the changes, so if you think my comments make sense, I'll be happy to merge your PR (ideally with the changed described below), and I'll iterate on those changes myself, whatever you prefer, just let me know.
Ideally, though, before merging this PR, I'd love to
- remove the
tokendefault from the module - remove the
dagger-demodirectory - Look into potential, unnecessary autogenerated code added (internal/dagger) checked in.
Thank you for your contribution!
Credentials for development
You mentioned that the token we provided didn't work, could you try this one?
export CHAINLOOP_TOKEN=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJvcmdfaWQiOiI4NDJmNTkzMS0yMWE0LTRlMTctOThhNC05NzBlOTU5OTliMDgiLCJ3b3JrZmxvd19pZCI6IjIwMTIyMDkwLWViZTItNDU2Yi04YzBhLTJiMThlYTQ5NjViNyIsImlzcyI6ImNwLmNoYWlubG9vcCIsImF1ZCI6WyJhdHRlc3RhdGlvbnMuY2hhaW5sb29wIl0sImp0aSI6IjU3ZDM3NmNkLTViMmQtNGYwOS04MTZiLTJiNjQ0NGU4N2E1NyJ9.blZmEc1YGf0CHXDBwmfEhFOwe6h7wXj4w6nrdSD_QUI
dagger call --token env:CHAINLOOP_TOKEN init [subcommand]
# note that most subcommands will panic due to the marshalling issue I mentioned inline in the code but once you fix that, you should be able to do things like
dagger call --token env:CHAINLOOP_TOKEN init with-file --file ./extras/dagger/dagger-demo/sbom.cyclonedx-1.5.json --name sbom status I hope it helps
shykes
force-pushed
the
dagger-improvements
branch
5 times, most recently
from
March 9, 2024 00:10
1297ab9 to
c048efa
Compare
migmartri
approved these changes
Mar 9, 2024
| type Chainloop struct {} | ||
|
|
||
| // Resume an attestation from its identifier | ||
| func (m *Chainloop) Resume( |
Member
There was a problem hiding this comment.
I love this resume functionality!
migmartri
reviewed
Mar 9, 2024
- Make the module address shorter: github.com/chainloop-dev/chainloop - New API takes advantage of chaining: do more in a single call, less glue scripts needed - Add descriptions to each function and type Signed-off-by: Solomon Hykes <solomon@dagger.io>
shykes
force-pushed
the
dagger-improvements
branch
from
March 9, 2024 00:36
c048efa to
74eca82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed improvements to the chainloop module.
To experiment, start with:
Normally, the demo token you provided is used by default, but I'm getting an auth error.