chore: decouple cas-client file upload - #43
Merged
Conversation
migmartri
commented
Mar 20, 2023
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
force-pushed
the
decouple-io-reader
branch
from
March 20, 2023 15:21
0b947cc to
e2432d6
Compare
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
This was referenced Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CAS client will be used by the control-plane too and the upload input in such case is an io.Reader not a file.
This patch updates the Uploader interface and implementation accordingly. It also keeps the
UploadFilemethod encapsulated in the casclient package since it's being used by two callers, the CLI action package and the attestation materials package.Refs #2