fix(dispatcher): do not fail if credentials are missing - #277
Merged
Conversation
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
danlishka
approved these changes
Jul 29, 2023
danlishka
left a comment
danlishka
left a comment
Member
There was a problem hiding this comment.
I think this is ok for now but we should build a better defined log + chainloop operator notifications in the future to let the admin or a person who added an integration know
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If during the integrations dispatch process one of the integrations can't find the credentials external dependency, it gets skipped instead of failing the execution.