Skip to content

feat(controlplane): make cas-backend used during attestation immutable - #237

Merged
migmartri merged 3 commits into
chainloop-dev:mainfrom
migmartri:link-cas-backend
Jul 12, 2023
Merged

feat(controlplane): make cas-backend used during attestation immutable#237
migmartri merged 3 commits into
chainloop-dev:mainfrom
migmartri:link-cas-backend

Conversation

@migmartri

Copy link
Copy Markdown
Member

We are preparing to support multiple cas backends #223. This patch makes sure that an attestation process, recorded as workflow run in the controlplane, maintains a reference to the cas backend(s in the future) through the whole attestation process (init, add and push)

This code maintains backwards compatibility with previous versions of the CLI.

Some highlights

  • New many<->many relationship between CAS backends and Workflow Runs
  • Association of CAS backend at init, and used during the whole att process, for both uploading artifacts and also calling the fanout dispatcher.

refs #223

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested a review from danlishka July 12, 2023 10:37
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

@danlishka danlishka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@migmartri
migmartri merged commit 6b408bb into chainloop-dev:main Jul 12, 2023
@migmartri
migmartri deleted the link-cas-backend branch July 12, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants