fix(release): do not fail if we can not attest a material - #231
Merged
Conversation
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Jul 10, 2023
| {type: "ARTIFACT", name: "cli-linux-amd64", output: true}, | ||
| {type: "ARTIFACT", name: "control-plane-linux-amd64", output: true}, | ||
| {type: "ARTIFACT", name: "artifact-cas-linux-amd64", output: true}, | ||
| {type: "ARTIFACT", name: "chainloop-plugin-discord-webhook-linux-amd64"}, |
Member
Author
There was a problem hiding this comment.
I'll also apply this change in the contract so we also attest this binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/chainloop-dev/chainloop/actions/runs/5507743809/jobs/10038247997
The issue was that now we are also building plugin binaries. Then we iterate over them and try to add them as pieces of evidence. Such pieces of evidence are not in the contract (yet).
This patch basically will do a graceful recover and move on. The verification will happen at
att pushwhere we make sure the required materials are in place.