Skip to content

feat: Added Slack plugin - #217

Merged
danlishka merged 6 commits into
chainloop-dev:mainfrom
danlishka:slack
Jul 4, 2023
Merged

feat: Added Slack plugin#217
danlishka merged 6 commits into
chainloop-dev:mainfrom
danlishka:slack

Conversation

@danlishka

@danlishka danlishka commented Jul 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

closes #216

Screenshot 2023-07-04 at 23 34 40

@danlishka
feat: Added Slack plugin, refs chainloop-dev#216
f0401db 
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka
danlishka requested a review from migmartri July 4, 2023 21:23
@migmartri

migmartri commented Jul 4, 2023

Copy link
Copy Markdown
Member

To make the test work, you need to run make generate in the controlplane. That will update the documentation for that plugin and the index.

migmartri
migmartri reviewed Jul 4, 2023
View reviewed changes
Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go Outdated
danlishka added 2 commits July 4, 2023 23:46
@danlishka
Renaming the slack plagin package and generating docs
4a13adf 
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka
Remove the G107 linting error
3069d56 
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
migmartri
migmartri reviewed Jul 4, 2023
View reviewed changes

@migmartri migmartri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly. The only change I'd suggest is to remove the registration state if it's not needed, other than that, it LGTM!

Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go Outdated
Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go Outdated
Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go Outdated
Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go Outdated
Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go
Comment thread app/controlplane/plugins/core/slack-webhook/v1/slack_webhook.go Outdated
danlishka added 3 commits July 5, 2023 00:10
@danlishka
Removed registrationState
2099122 
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka
Typo fixed
cf153e2 
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka
Added a backticks comment
d5c8540 
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka danlishka self-assigned this Jul 4, 2023
migmartri
migmartri approved these changes Jul 4, 2023
View reviewed changes

@migmartri migmartri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@migmartri

migmartri commented Jul 4, 2023

Copy link
Copy Markdown
Member

@danlishka JFYI since this comment might get lost in the back and forth #217 (comment)

@danlishka

danlishka commented Jul 4, 2023

Copy link
Copy Markdown
Member Author

@danlishka JFYI since this comment might get lost in the back and forth #217 (comment)

I have already added a comment. Thanks!

@danlishka
danlishka merged commit 95f814f into chainloop-dev:main Jul 4, 2023
@danlishka
danlishka deleted the slack branch July 4, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migmartri migmartri migmartri approved these changes

Assignees

@danlishka danlishka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(integrations) Slack

2 participants

@danlishka @migmartri