feat(integrations): new dispatcher mode - #206
Merged
Merged
Conversation
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
marked this pull request as draft
June 23, 2023 14:15
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
marked this pull request as ready for review
June 23, 2023 15:10
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the dispatcher and sdk to enable
aggregated mode, more on that here #205The summary of the change would be
attestation envelope, you'll always get that.This makes the execution mode conceptually easier to understand and explain. An integration will be called each time an attestation is received, and it might contain some materials of the type you've subscribed to.
re: dispatcher changes
The code has been simplified by following a hydration pattern where we make a queue of possible dispatches go through a series of hydration steps, 1) initialize queue and with integration configurations from the DB, 2) add attestation and material information, 3) add chainloop metadata and 4) dispatch
This new mode enables developers for example to be able to send the materials they care alongside the attestation at once, see example of a discord POC below
Closes #205