Skip to content

fix: nil pointer guard when no attestation is present - #185

Merged
migmartri merged 1 commit into
chainloop-dev:mainfrom
migmartri:fix-attestation
Jun 19, 2023
Merged

fix: nil pointer guard when no attestation is present#185
migmartri merged 1 commit into
chainloop-dev:mainfrom
migmartri:fix-attestation

Conversation

@migmartri

Copy link
Copy Markdown
Member

Closes #184

Now the CLI shows there was an issue retrieving the attestation which was the original behavior, or "there is an attestation in progress"

$chainloop wf run describe --id 0c27d5d0-cc38-418c-a933-46b9ef02a532
┌───────────────────────────────────────────────────────┐
│ Workflow                                              │
├────────────────┬──────────────────────────────────────┤
│ ID             │ 548995cd-e64a-4f7f-bb6b-789f8fc07afb │
│ Name           │ test                                 │
│ Team           │                                      │
│ Project        │ baz                                  │
├────────────────┼──────────────────────────────────────┤
│ Workflow Run   │                                      │
├────────────────┼──────────────────────────────────────┤
│ ID             │ 0c27d5d0-cc38-418c-a933-46b9ef02a532 │
│ Initialized At │ 15 Jun 23 15:18 UTC                  │
│ Finished At    │ 15 Jun 23 15:18 UTC                  │
│ State          │ success                              │
│ Runner Link    │                                      │
└────────────────┴──────────────────────────────────────┘
WRN there was an issue retrieving the attestation

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
migmartri requested a review from danlishka June 19, 2023 10:29
@migmartri
migmartri merged commit 3e52722 into chainloop-dev:main Jun 19, 2023
@migmartri
migmartri deleted the fix-attestation branch June 19, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal error while describing legacy attestation

2 participants