feat(cli): allow setting default values for Control Plane and CAS - #109
Merged
Conversation
Member
|
Awesome! As a follow up it could be good to update the upstream docs to link to this alternate method of configuring the CLI https://docs.chainloop.dev/getting-started/installation#configure-cli-optional |
migmartri
reviewed
May 8, 2023
…points endpoints at the CLI build time Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
migmartri
reviewed
May 8, 2023
| flagOutputFormat string | ||
| actionOpts *action.ActionsOpts | ||
| logger zerolog.Logger | ||
| defaultCpAPI = "api.cp.chainloop.dev:443" |
Member
There was a problem hiding this comment.
since CAS and CP are acronyms, I'd update them.
defaultCpAPI => defaultCPAPI
defaultCasAPI => defaultCASAPI
migmartri
reviewed
May 8, 2023
|
|
||
| By default CLI uses the following values for the Control Plane and Artifacts CAS API endpoints: | ||
|
|
||
| - Artifacts CAS: api.cas.chainloop.dev:443 |
Member
There was a problem hiding this comment.
Note for another pull request (no need to block this one). To make it clear, I'd indicate that this is optional, that these values can be overridden "at runtime" on a need-to-need basis. https://github.com/chainloop-dev/chainloop#configure-cli-optional
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
migmartri
approved these changes
May 8, 2023
migmartri
left a comment
migmartri
left a comment
Member
There was a problem hiding this comment.
LGTM!
Congrats and welcome!! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow setting default values for Control Plane and CAS enpoints endpoints at the CLI build time
closes #96