Skip to content

chore(oci registry): show validation error during save - #106

Merged
migmartri merged 1 commit into
chainloop-dev:mainfrom
migmartri:105-oci-validation-error
May 5, 2023
Merged

chore(oci registry): show validation error during save#106
migmartri merged 1 commit into
chainloop-dev:mainfrom
migmartri:105-oci-validation-error

Conversation

@migmartri

@migmartri migmartri commented May 5, 2023

Copy link
Copy Markdown
Member

During OCI registry save, we now

  • Capture and returns validation error with plain message instead of generic 500 error
  • Do not send an exception to sentry in that case

Before (CLI output)

ERR server error

After

ERR invalid repository URI: repository can only contain the characters `abcdefghijklmnopqrstuvwxyz0123456789_-./`: [REPO_URI]

Closes #105

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri changed the title chore: show validation error chore(oci registry): show validation error during save May 5, 2023
@migmartri
migmartri merged commit 477087c into chainloop-dev:main May 5, 2023
@migmartri
migmartri deleted the 105-oci-validation-error branch May 5, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle invalid error during the OCI registry registration

1 participant