plan once before apply (#2786)

* don't plan before apply Signed-off-by: Jason Hall <jason@chainguard.dev> * mega plan Signed-off-by: Jason Hall <jason@chainguard.dev> * fix it real good Signed-off-by: Jason Hall <jason@chainguard.dev> --------- Signed-off-by: Jason Hall <jason@chainguard.dev>
chainguard-images · Jun 3, 2024 · ad26a6d · ad26a6d
1 parent 72e6c73
commit ad26a6d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/presubmit-build.yaml b/.github/workflows/presubmit-build.yaml
@@ -181,13 +181,10 @@ jobs:
         targets=""
         for image in ${{ matrix.shard.images }}; do
           targets+=' -target='module."${image}"''
-
-          echo "::group::Plan for ${image}"
-          terraform plan -target=module."${image}"
-          echo "::endgroup::"
         done
 
-        terraform apply ${targets} -auto-approve --parallelism=$(nproc) -json | tee /tmp/mega-module.tf.json | jq -r '.["@message"]'
+        terraform plan ${targets} -out=plan.tfplan
+        terraform apply ${targets} -auto-approve --parallelism=$(nproc) -json plan.tfplan | tee /tmp/mega-module.tf.json | jq -r '.["@message"]'
 
     - name: Collect TF diagnostics
       if: ${{ always() }}

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -119,13 +119,10 @@ jobs:
           targets=""
           for image in ${{ matrix.shard.images }}; do
             targets+=' -target='module."${image}"''
-
-            echo "::group::Plan for ${image}"
-            terraform plan -target=module."${image}"
-            echo "::endgroup::"
           done
 
-          terraform apply ${targets} -auto-approve --parallelism=$(nproc) -json | tee /tmp/mega-module.tf.json | jq -r '.["@message"]'
+          terraform plan ${targets} -out mega-module.tfplan
+          terraform apply ${targets} -auto-approve --parallelism=$(nproc) -json mega-module.tfplan | tee /tmp/mega-module.tf.json | jq -r '.["@message"]'
 
       - name: Collect TF diagnostics
         if: ${{ always() }}