Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support s3 as cache #567

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support s3 as cache #567

wants to merge 2 commits into from

Conversation

gtn3010
Copy link

@gtn3010 gtn3010 commented Jul 24, 2023

No description provided.

@gtn3010 gtn3010 requested a review from a team as a code owner July 24, 2023 02:57
@gtn3010 gtn3010 requested review from rawlingsj and removed request for a team July 24, 2023 02:57
@tektondeploy tektondeploy force-pushed the add_support_s3 branch 4 times, most recently from 0473fb7 to 293589b Compare July 24, 2023 03:50
@kaniini
Copy link
Contributor

kaniini commented Jul 26, 2023

Needs go mod tidy, but it would be nice to abstract this a little more than just an if/else block.

@gtn3010
Add support s3 as cache
a3464b1 
Signed-off-by: Nguyen GT <gtn3010@gmail.com>
@gtn3010
Copy link
Author

gtn3010 commented Jul 29, 2023 •
edited
Loading

Hi, Could you give me some hints? Like should I create a new package named remote cache with methods fetch bucket/upload bucket for each provider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlingsj rawlingsj Awaiting requested review from rawlingsj rawlingsj was automatically assigned from chainguard-dev/images-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtn3010 @kaniini