Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

remove duplicate additionalPrinterColumns #192

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

k4leung4
Copy link
Collaborator

@k4leung4 k4leung4 commented Nov 3, 2023

patch for knative/serving#14592

remove duplicate 'additionalPrinterColumns' in domain-mapping resource, was seeing

error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 153: mapping key "additionalPrinterColumns" already defined at line 31

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97f6b43) 70.76% compared to head (813de05) 70.76%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   70.76%   70.76%           
=======================================
  Files           4        4           
  Lines         195      195           
=======================================
  Hits          138      138           
  Misses         40       40           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k4leung4 k4leung4 force-pushed the fix-dupe branch 2 times, most recently from d8c73c1 to 63a5a8e Compare November 3, 2023 21:10
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4 k4leung4 merged commit 4faeb86 into chainguard-dev:main Nov 6, 2023
@k4leung4 k4leung4 deleted the fix-dupe branch November 6, 2023 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants