[WIP] Increase width of index pages #2377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
changed the title
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Also pull descriptions for topic page buttons on tag pages into the button to improve alignment and readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
What should this PR do?
Increase width of index pages such as https://edu.chainguard.dev/software-security/learning-labs/# to be consistent with other doc pages without messing out layout otherwise.
Currently the tags pages (and sections?) look bad since the buttons are center aligned and wide and the description is left aligned. The same issue exists originally but its less obvious due to the narrower width and the centering of the whole page.
I also played with getting rid of the use of buttons and in my opionion that would be even better.
Another option would be to get rid of the description .. in most cases it seems to be a reworded longer version of the title and is not really that useful.
Why are we making this change?
Improve look and feel and usability.
Fix https://github.com/chainguard-dev/internal/issues/5158
What are the acceptance criteria?
Review and testing to verify that layout is better than before..
How should this PR be tested?
check various pages for impact.