Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use attrs<19.2.0 with pytest #569

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Use attrs<19.2.0 with pytest #569

merged 2 commits into from
Oct 18, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Oct 18, 2019

I opened a new PR that is the same as #568 since TravisCI somehow tries to fetch the branch from chainer/chainerrl and fails.

@muupan
Copy link
Member Author

muupan commented Oct 18, 2019

Oops, continuous-integration/travis-ci/push is still there. Maybe it is checking the commit hash.

toslunar
toslunar approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit a091e3f into chainer:master Oct 18, 2019
@muupan muupan deleted the attrs-version2 branch October 18, 2019 10:14
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @toslunar