Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass env_id to replay_buffer methods to fix batch training #558

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Pass env_id to replay_buffer methods to fix batch training #558

merged 3 commits into from
Oct 24, 2019

Conversation

ummavi
Copy link
Member

@ummavi ummavi commented Sep 19, 2019

Fixes issue #557

@ummavi ummavi requested a review from muupan September 19, 2019 04:19
@ummavi
Copy link
Member Author

ummavi commented Sep 19, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit a081231:

prabhatnagarajan
prabhatnagarajan approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prabhatnagarajan
Copy link
Contributor

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 9d20979:

@muupan
Copy link
Member

muupan commented Oct 24, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit e758219:

@muupan muupan merged commit a6c3c50 into chainer:master Oct 24, 2019
@ummavi ummavi deleted the sac_rbuff_fix branch November 11, 2019 04:02
@ummavi ummavi mentioned this pull request Nov 11, 2019
Closed
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

@muupan muupan Awaiting requested review from muupan

Assignees
No one assigned
Labels
bug prio:high
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@ummavi @pfn-ci-bot @prabhatnagarajan @muupan