Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits Replay Buffers into separate files in a replay_buffers module #506

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

prabhatnagarajan
Copy link
Contributor

As the number of different types of replay buffers grows, it makes more sense to have a dedicated directory for the different types of replay buffers. This PR does that, while maintaining backwards compatibility.

Copy link
Contributor

@marioyc marioyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@prabhatnagarajan prabhatnagarajan merged commit 2c335e2 into chainer:master Jul 16, 2019
@prabhatnagarajan prabhatnagarajan deleted the replay_module branch July 23, 2019 13:04
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants