Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename examples directories #487

Merged
merged 20 commits into from
Jul 1, 2019
Merged

Rename examples directories #487

merged 20 commits into from
Jul 1, 2019

Conversation

keisuke-nakata
Copy link
Member

@keisuke-nakata keisuke-nakata commented Jun 19, 2019 •
edited
Loading

Rename some directories under examples/:

update:

ale -> atari
atari -> atari/reproduction
mujoco -> mujoco/reproduction
mujoco tasks in gym/ -> mujoco

@keisuke-nakata keisuke-nakata changed the title Rename examples directories [WIP] Rename examples directories Jun 19, 2019
@keisuke-nakata
Copy link
Member Author

For reviewers:
Please check the diff for each commit.
The final diff of this PR is confusing, because examples_tests/atari/test_dqn.sh is renamed to examples_tests/atari/reproduction/test_dqn.sh but also examples_tests/atari/test_dqn.sh is renamed from examples_tests/ale/test_dqn.sh.

@keisuke-nakata keisuke-nakata changed the title [WIP] Rename examples directories Rename examples directories Jun 19, 2019
prabhatnagarajan
prabhatnagarajan reviewed Jun 25, 2019
View reviewed changes
examples/README.md
- `gym`: examples for OpenAI Gym environments
- `grasping`: examples for a Bullet-based robotic grasping environment
- `mujoco`: examples with benchmark scores for reproducing published results on MuJoCo tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mujoco/reproduction be in gym/reproduction? Or should we move gym tasks that use mujoco into mujoco @muupan ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is, should we have a mujoco and mujoco/reproduction directory, where mujoco tasks formerly in gym move to mujoco?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @prabhatnagarajan @muupan , I'll fix this.

@keisuke-nakata
Copy link
Member Author

keisuke-nakata commented Jun 28, 2019 •
edited
Loading

@prabhatnagarajan I moved mujoco scripts formerly in gym, but should I move the corresponding tests as well?
The target environment for mujoco scripts' tests are actually Pendulum-v0 to avoid mujoco license.

I moved the corresponding test scripts, according to the existing examples_tests/mujoco tests.

prabhatnagarajan
prabhatnagarajan suggested changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes. Looks good though.

examples_tests/mujoco/test_ppo_batch.sh Outdated Show resolved Hide resolved
examples_tests/mujoco/test_ddpg_batch.sh Outdated Show resolved Hide resolved
examples/mujoco/README.md Outdated Show resolved Hide resolved
examples/mujoco/README.md Outdated Show resolved Hide resolved
examples/mujoco/README.md Outdated Show resolved Hide resolved
examples_tests/mujoco/test_td3.sh
outdir=$(mktemp -d)

gpu="$1"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was not removed but renamed cd7180b#diff-9784aa586d342815241085cc9b58991a
(The final diff shows misleading results because I fixed the content of files at same time)

keisuke-nakata and others added 5 commits July 1, 2019 10:46
@keisuke-nakata @prabhatnagarajan
Update examples_tests/mujoco/test_ppo_batch.sh
156990e 
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
@keisuke-nakata @prabhatnagarajan
Update examples_tests/mujoco/test_ddpg_batch.sh
de52f96 
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
@keisuke-nakata @prabhatnagarajan
Update examples/mujoco/README.md
b28ea54 
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
@keisuke-nakata @prabhatnagarajan
Update examples/mujoco/README.md
64cfd08 
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
@keisuke-nakata @prabhatnagarajan
Update examples/mujoco/README.md
0671f2a 
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
prabhatnagarajan
prabhatnagarajan approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small change.

examples_tests/atari/test_dqn_batch.sh Outdated Show resolved Hide resolved
@keisuke-nakata @prabhatnagarajan
Update examples_tests/atari/test_dqn_batch.sh
16caced 
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
@keisuke-nakata keisuke-nakata merged commit 673e8ce into chainer:master Jul 1, 2019
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
@muupan muupan added the example label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees
No one assigned
Labels
example
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@keisuke-nakata @prabhatnagarajan @muupan