Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match EpisodicReplayBuffer.sample with ReplayBuffer.sample #485

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Match EpisodicReplayBuffer.sample with ReplayBuffer.sample #485

merged 1 commit into from
Jun 17, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Jun 14, 2019

Resolves #484

@muupan muupan changed the title Math EpisodicReplayBuffer.sample with ReplayBuffer.sample Match EpisodicReplayBuffer.sample with ReplayBuffer.sample Jun 14, 2019
@prabhatnagarajan prabhatnagarajan self-assigned this Jun 14, 2019
prabhatnagarajan
prabhatnagarajan approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit 81be9c8 into chainer:master Jun 17, 2019
@muupan muupan deleted the fix-episodic-replay-buffer-sample branch June 17, 2019 13:09
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
@muupan muupan added the bug label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees

@prabhatnagarajan prabhatnagarajan

Labels
bug
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Mismatch between EpisodicReplayBuffer.sample and ReplayBuffer.sample
2 participants
@muupan @prabhatnagarajan