Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to references #425

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Add links to references #425

merged 1 commit into from
Apr 2, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Mar 31, 2019

Some of the docstrings may not be sufficient, but I think it is better than nothing.

@muupan muupan mentioned this pull request Mar 31, 2019
Merged
1 task
@toslunar toslunar self-assigned this Apr 1, 2019
@toslunar toslunar self-requested a review April 2, 2019 09:44
prabhatnagarajan
prabhatnagarajan approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Checked the outputted HTML.

@prabhatnagarajan prabhatnagarajan merged commit f8bff03 into chainer:master Apr 2, 2019
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

@toslunar toslunar Awaiting requested review from toslunar

Assignees

@toslunar toslunar

Labels
documentation
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@muupan @prabhatnagarajan @toslunar