Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce ACER's test cases and maximum timesteps #404

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Reduce ACER's test cases and maximum timesteps #404

merged 1 commit into from
Feb 28, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Feb 25, 2019

  • use_lstm=False was tested for t_max=1,2,5. This PR changes it to t_max=1,2 because I think it is sufficient. use_lstm=True=True is tested for t_max=5 as before.
  • Test cases where n_times_replay=0 and disable_online_update=True were tested twice. This PR skips one of them.
  • Maximum of timesteps is reduced to avoid consuming too much time on failed tests.

@muupan
Copy link
Member Author

muupan commented Feb 25, 2019

These are terminal outputs of running the ACER tests 10 times before and after the commit 689c83b.
acer_tests_after.txt
acer_tests_before.txt
Before the commit, it took 318-364 seconds. After the commit, it took 211-243 seconds.

@muupan
Copy link
Member Author

muupan commented Feb 25, 2019

imosci test this please

@pfn-ci-bot
Copy link
Collaborator

imosCI successfully created a job for commit 689c83b:

prabhatnagarajan
prabhatnagarajan approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about this offline; Changes all look good. Merge at will.

@muupan muupan merged commit 88e1b44 into chainer:master Feb 28, 2019
@muupan muupan added the test label Feb 28, 2019
@muupan muupan added this to the v0.6 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@muupan @pfn-ci-bot @prabhatnagarajan