Implements Time-based evaluations #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhatnagarajan
changed the title
muupan
requested changes
Jan 7, 2019
muupan
requested changes
Jan 7, 2019
muupan
reviewed
Jan 8, 2019
|
It looks good except for suggested changes. |
|
Can you fix the autopep8 error of CI? |
muupan
approved these changes
Jan 8, 2019
|
I think it's ok to merge. CI failures should be fixed by #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables time-based evaluations in order to mirror deepmind's evaluation protocols more accurately. Previous versions of ChainerRL only supported episodic evaluations (i.e. evaluations spanning a certain number of episodes). However, this PR does not support Asynchronous time-based evaluations.