Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render wrapper #350

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Render wrapper #350

merged 4 commits into from
Nov 13, 2018

Conversation

muupan
Copy link
Member

@muupan muupan commented Nov 12, 2018

This PR adds chainerrl.wrappers.Render, an Env wrapper that calls env.render after every env.reset and env.step. All the examples that uses chainerrl.misc.env_modifiers.make_rendered switch to use the new wrapper.

Somehow chainerrl.misc.env_modifiers.make_rendered stopped to work correctly for atari environments, and this PR is needed to fix this issue.

I confirmed that all the affected examples work with rendering enabled.

@muupan muupan mentioned this pull request Nov 12, 2018
3 tasks
@prabhatnagarajan prabhatnagarajan self-assigned this Nov 12, 2018
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@muupan muupan merged commit dd38230 into chainer:master Nov 13, 2018
@muupan muupan deleted the render-wrapper branch November 13, 2018 07:20
@muupan muupan added this to the v0.5 milestone Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants